[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 27 14:16:17 PST 2020


nickdesaulniers added a comment.

In D73319#1842951 <https://reviews.llvm.org/D73319#1842951>, @void wrote:

> In D73319#1842900 <https://reviews.llvm.org/D73319#1842900>, @nickdesaulniers wrote:
>
> > Great idea; thanks for the patch! Needs documentation. :)
>
>
> I can't find a place for documentation of extensions, at least not the names of extensions like `gnu_asm`.


How about https://clang.llvm.org/docs/LanguageExtensions.html#checks-for-standard-language-features ? Then we can add both `gnu_asm` and `gnu_asm_goto_with_outputs`.



================
Comment at: clang/test/Parser/asm-goto.c:9
+#error Extension 'gnu_asm_goto_with_outputs' should be available by default
+#endif
 
----------------
ah, sorry, maybe a test that makes use of `asm goto` + output constraints? Maybe if you base your patch on top of the others in the series that implement the feature?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73319/new/

https://reviews.llvm.org/D73319





More information about the cfe-commits mailing list