[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:340
+    return false;
+  if (FDecl->getAccess() == AS_private || FDecl->getAccess() == AS_protected)
+    return false;
----------------
njames93 wrote:
> aaron.ballman wrote:
> > I'd flip the logic to `!= AS_public` to be more clear that we only care about public members.
> What do you think about AS_none, its a weird case and shall i ignore it. I'm guessing all functions not in a class are implicitly declared to be public.
Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73098/new/

https://reviews.llvm.org/D73098