[PATCH] D73307: Unique Names for Functions with Internal Linkage

Sriraman Tallam via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 24 14:48:17 PST 2020


tmsriram marked an inline comment as done.
tmsriram added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1117
+    llvm::MD5::stringifyResult(R, Str);
+    std::string UniqueSuffix = (".$" + Str).str();
+    MangledName = MangledName + UniqueSuffix;
----------------
pcc wrote:
> Why `".$"` and not just `"."`?
I just wanted to keep it consistent with what getUniqueModuleId does with the Md5 hash.  I can remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73307/new/

https://reviews.llvm.org/D73307





More information about the cfe-commits mailing list