[PATCH] D73307: Unique Names for Functions with Internal Linkage

[Sriraman Tallam via Phabricator via cfe-commits]

tmsriram marked an inline comment as done.
tmsriram added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:966
                                          OPT_fno_unique_section_names, true);
+  Opts.UniqueInternalFuncNames = Args.hasFlag(
+      OPT_funique_internal_funcnames, OPT_fno_unique_internal_funcnames, false);
----------------
MaskRay wrote:
> Just `Args.hasArg(OPT_funique_internal_funcnames)`.
> 
> `-fno-*` is handled in clangDriver. CC1 does not need to know `-fno-*` if it defaults to false.
Are you suggesting I remove the -fno-* flag? The -fno-* is useful  if -funique-internal-funcnames came added to a Makefile ,for example, and this needs to be disabled.  This is similar to say -ffunction-sections.  Please clarify. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73307/new/

https://reviews.llvm.org/D73307