[PATCH] D73363: Verify that clang's max alignment is <= LLVM's max alignment
David Zarzycki via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 24 09:00:31 PST 2020
davezarzycki created this revision.
davezarzycki added a reviewer: lebedev.ri.
davezarzycki added projects: LLVM, clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D73363
Files:
clang/include/clang/Sema/Sema.h
clang/lib/CodeGen/CGValue.h
Index: clang/lib/CodeGen/CGValue.h
===================================================================
--- clang/lib/CodeGen/CGValue.h
+++ clang/lib/CodeGen/CGValue.h
@@ -15,12 +15,16 @@
#define LLVM_CLANG_LIB_CODEGEN_CGVALUE_H
#include "clang/AST/ASTContext.h"
+#include "clang/Sema/Sema.h"
#include "clang/AST/Type.h"
#include "llvm/IR/Value.h"
#include "llvm/IR/Type.h"
#include "Address.h"
#include "CodeGenTBAA.h"
+static_assert(clang::Sema::MaximumAlignment <= llvm::Value::MaximumAlignment,
+ "Clang max alignment greater than what LLVM supports?");
+
namespace llvm {
class Constant;
class MDNode;
Index: clang/include/clang/Sema/Sema.h
===================================================================
--- clang/include/clang/Sema/Sema.h
+++ clang/include/clang/Sema/Sema.h
@@ -372,16 +372,17 @@
QualType ResultTy,
ArrayRef<QualType> Args);
+public:
/// The maximum alignment, same as in llvm::Value. We duplicate them here
/// because that allows us not to duplicate the constants in clang code,
/// which we must to since we can't directly use the llvm constants.
+ /// The value is verified against llvm here: lib/CodeGen/CGValue.h
///
/// This is the greatest alignment value supported by load, store, and alloca
/// instructions, and global values.
static const unsigned MaxAlignmentExponent = 29;
static const unsigned MaximumAlignment = 1u << MaxAlignmentExponent;
-public:
typedef OpaquePtr<DeclGroupRef> DeclGroupPtrTy;
typedef OpaquePtr<TemplateName> TemplateTy;
typedef OpaquePtr<QualType> TypeTy;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73363.240218.patch
Type: text/x-patch
Size: 1667 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200124/9f3acb12/attachment-0001.bin>
More information about the cfe-commits
mailing list