[PATCH] D73229: [analyzer] Improve FuchsiaHandleChecker's diagnostic messages

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 23 08:47:34 PST 2020


NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:363
           } else
-            return "";
+            return std::string{};
         });
----------------
xazax.hun wrote:
> NoQ wrote:
> > What was wrong with good old `""`?
> I had two returns with different types so I either need to specify the return type of the lambda explicitly or make the two returns return the same type.
Oh, right.

I think i specified the return type explicitly in most places but that's not a must.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73229/new/

https://reviews.llvm.org/D73229





More information about the cfe-commits mailing list