[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 23 08:19:49 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:132
   }
+
   return false;
----------------
Don't change formatting of code this patch doesn't need to touch


================
Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:153
   }
+
   return Result;
----------------
likewise


================
Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:197
+        std::string AdditionalVarNames = getCondVarNames(Init);
+        if (!AdditionalVarNames.empty()) {
+          CondVarNames += ", " + AdditionalVarNames;
----------------
elide braces


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73270/new/

https://reviews.llvm.org/D73270





More information about the cfe-commits mailing list