[PATCH] D73185: [AST] Add fixed-point subtraction constant evaluation.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 22 19:12:57 PST 2020


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM other than the request to split the commit.



================
Comment at: clang/include/clang/Basic/FixedPoint.h:82
+  unsigned IsSaturated    : 1;
+  unsigned HasUnsignedPadding : 1;
 };
----------------
These changes should probably be done in a separate patch.

I don't have a problem with compressing this type, but I'm curious if there was a concrete motivation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73185/new/

https://reviews.llvm.org/D73185





More information about the cfe-commits mailing list