[PATCH] D73120: [Clang] Alternate fix for "expansion of response files in -Wp after integrated-cc1 change"

Wed Jan 22 13:55:03 PST 2020

aganea marked 3 inline comments as done.
aganea added inline comments.

================
Comment at: clang/test/Driver/Wp-args.c:27
+
+// RSP: inception
----------------
hans wrote:
> aganea wrote:
> > hans wrote:
> > > Why inception? I feel like I'm missing something :)
> > Could be anything else :) Because `-rewrite-macros` prints this .c with comments, and then FileCheck looks for that tag in stdout.
> Ah, I see.
> 
> Do you think it would be possible to do something simpler, like just pass a -D flag and check that it gets set? That would be easier for future readers of the test to understand.
Done in the commit.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73120/new/

https://reviews.llvm.org/D73120