[PATCH] D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 22 10:05:14 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:726
+      unsigned ErrorIndex = ErrorAndDiscarded.first;
+      const auto &Discarded = ErrorAndDiscarded.second;
+      if (!Apply[ErrorIndex])
----------------
Eugene.Zelenko wrote:
> Please don't use auto unless type is spelled in same statement or iterator.
What if the type is ``llvm::SmallDenseSet<const clang::tooling::Replacement *, 4, llvm::DenseMapInfo<const clang::tooling::Replacement *> >``


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73203/new/

https://reviews.llvm.org/D73203





More information about the cfe-commits mailing list