[PATCH] D73005: [Codegen] If reasonable, materialize clang's `AssumeAlignedAttr` as llvm's Alignment Attribute on call-site function return value

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 15:09:29 PST 2020


lebedev.ri marked 2 inline comments as done.
lebedev.ri added inline comments.


================
Comment at: clang/test/CodeGen/assume-aligned-and-alloc-align-attributes.c:12
 // CHECK-NEXT:    [[MASKCOND:%.*]] = icmp eq i64 [[MASKEDPTR]], 0
 // CHECK-NEXT:    call void @llvm.assume(i1 [[MASKCOND]])
 // CHECK-NEXT:    ret i8* [[CALL]]
----------------
jdoerfert wrote:
> Why would we still emit the llvm.assume here?
Because it is for the second/other attribute - `__attribute__((alloc_align(2)))`.
This is **potentially** fixed by the next patch - D73006.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73005/new/

https://reviews.llvm.org/D73005





More information about the cfe-commits mailing list