[PATCH] D72434: Support offset of member designator with the arrow for __builtin_offsetof

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 14:05:50 PST 2020


efriedma added a comment.

Testcase?

I assume we give appropriate errors if you try to use "->" on a member that's not an array?



================
Comment at: clang/lib/Parse/ParseExpr.cpp:2168
 
-    // FIXME: This loop leaks the index expressions on error.
     while (1) {
----------------
Did you fix this FIXME? Or does it no longer apply?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72434/new/

https://reviews.llvm.org/D72434





More information about the cfe-commits mailing list