[PATCH] D72996: [Sema] Attempt to perform call-size-specific `__attribute__((alloc_align(param_idx)))` validation

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 21 13:28:48 PST 2020


lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4479
+    const Expr *Arg = Args[AA->getParamIndex().getASTIndex()];
+    if (!Arg->isTypeDependent() && !Arg->isValueDependent()) {
+      llvm::APSInt I(64);
----------------
erichkeane wrote:
> Does this need to be isInstantionDependent?
I'm not sure, should it be?
It seems there is no such check in `Sema::SemaBuiltinAssumeAligned()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72996/new/

https://reviews.llvm.org/D72996





More information about the cfe-commits mailing list