[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

[Nathan James via Phabricator via cfe-commits]

njames93 created this revision.
njames93 added reviewers: aaron.ballman, JonasToth, alexfh, hokein.
njames93 added projects: clang, clang-tools-extra.
Herald added subscribers: kristof.beyls, xazax.hun.

Typically most main functions have the signature:

  int main(int argc, char *argv[])

To stick with convention when renaming parameters we should ignore the `argc` and `argv` names even if the parameter style says they should be renamed. This patch addresses this by checking all ParmVarDecls if they form part of a function with a signature that matches main `int name(int argc, char * argv[], (optional char *env[]))`


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73098

Files:
  clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-main-like.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73098.239293.patch
Type: text/x-patch
Size: 5336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200121/85981eac/attachment-0001.bin>