[PATCH] D73088: [clangd] Capture the missing injected class names in findExplicitReferences.

Tue Jan 21 03:43:51 PST 2020

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:736
+              template <typename $0^T>
+              class $1^$2^Bar {
+                ~$3^Bar();
----------------
kadircet wrote:
> looks like we are getting duplicates here
looking at this again, this is actually not caused by this change, it was always there we just didn't notice it before since no one tested class templates.

could you put a fixme on it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73088/new/

https://reviews.llvm.org/D73088