[PATCH] D71512: [clang-format] Fix short block when braking after control statement

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.

In D71512#1815512 <https://reviews.llvm.org/D71512#1815512>, @Bouska wrote:

> Ping @MyDeveloperDay @klimek






================
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:344
-      return MergedLines;
-    }
     // Don't merge block with left brace wrapped after ObjC special blocks
----------------
I just can't understand how we are free to just remove a chunk of code. Why is this not being some sort of 


```
if (Style.AllowShortBlocksOnASingleLine)
```

You are just not giving a convincing argument that this is a safe change without us having to go in a debug the original problem ourselves.


================
Comment at: clang/unittests/Format/FormatTest.cpp:662
                "{\n"
-               "  ffffffffffffffffffffffffffffffffffffffffffffffffffffff();\n"
                "}",
----------------
I'm just not comfortable with changing tests, code can still be written in the way it was before, and I cannot tell what it would now be, I believe tests should be additive


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71512/new/

https://reviews.llvm.org/D71512