[PATCH] D69585: PerformPendingInstatiations() already in the PCH

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 18 07:58:08 PST 2020


aganea added inline comments.


================
Comment at: clang/lib/Sema/Sema.cpp:984
+
+    PerformPendingInstantiations();
   }
----------------
All tests pass if you add `if (LangOpts.BuildingPCHWithObjectFile)` here. But if a specialization occurs inside a .CPP which includes the .PCH, not sure what would/should happen, and if that'S handled. Definitely needs a test for that. @rsmith WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69585/new/

https://reviews.llvm.org/D69585





More information about the cfe-commits mailing list