[PATCH] D72848: Remove some SVN-specific code.

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 17 10:13:21 PST 2020


Eugene.Zelenko added inline comments.


================
Comment at: clang/lib/Basic/Version.cpp:33
 #else
-  StringRef URL("");
+  return "";
 #endif
----------------
hans wrote:
> Eugene.Zelenko wrote:
> > return {} should be better.
> Why? I think "" is clearer for a string.
It's default non-trivial object initialization. Also not need for implicit cast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72848/new/

https://reviews.llvm.org/D72848





More information about the cfe-commits mailing list