[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

Michael Wyman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 16 14:06:10 PST 2020


mwyman created this revision.
mwyman added reviewers: stephanemoore, benhamilton.
mwyman added projects: clang-tools-extra, clang.
Herald added subscribers: cfe-commits, mgehre, mgorny.

Such implementations may override the class's own implementation, and even be a danger in case someone later comes and adds one to the class itself. Most times this has been encountered have been a mistake.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D72876

Files:
  clang-tools-extra/clang-tidy/objc/CMakeLists.txt
  clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp
  clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.h
  clang-tools-extra/clang-tidy/objc/ObjCTidyModule.cpp
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/list.rst
  clang-tools-extra/docs/clang-tidy/checks/objc-dealloc-in-categories.rst
  clang-tools-extra/test/clang-tidy/checkers/objc-dealloc-in-categories.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72876.238611.patch
Type: text/x-patch
Size: 7455 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200116/56f78e15/attachment-0001.bin>


More information about the cfe-commits mailing list