[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

Vlad Vereschaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 16 12:47:34 PST 2020


vvereschaka added a comment.

Hi Sergej,

as far as I understood '--param enable_filesystem=False' argument is libc++ specific, but we pass those parameters to all the library tests.
I think it is optimal to pass this parameter directly in the builder configuration only for libcxx as '-DLLVM_LIT_ARGS="--param enable_filesystem=False"'.
Everything else looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72717/new/

https://reviews.llvm.org/D72717





More information about the cfe-commits mailing list