[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

[James Y Knight via Phabricator via cfe-commits]

jyknight added inline comments.
Herald added a project: clang.


================
Comment at: lib/Headers/__stddef_max_align_t.h:44
+#endif
 } max_align_t;
 #endif
----------------
EricWF wrote:
> rsmith wrote:
> > I don't want to hold up the immediate fix in this patch for this, but... we should move the definition of this type from the header into clang itself, like we do for (say) `__builtin_va_list`, and here just define
> > 
> > `typedef __builtin_max_align_t max_align_t;`
> > 
> > That way Clang can synthesize a struct of whatever size and alignment appropriate from an ABI perspective (or can use the relevant builtin type for platforms that typedef `max_align_t` to a builtin type). That'd also remove the need for an awkward factored-out header file here.
> I'll try to implement this over the weekend. As long as I can land the Clang fix required for libc++ cleanup before the next release.
Looks like this patch never landed. I think it still should be, right?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55057/new/

https://reviews.llvm.org/D55057