[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 14 16:12:25 PST 2020


rnk added a comment.

I think I liked the first version of this patch better. I would say, if the AST after instantiation remains the same as it was before D69950 <https://reviews.llvm.org/D69950>, then the first one seems like the right fix. The pattern AST will just be missing a node to represent the promotion from the bitfield to a full integer, and then again to a boolean.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72242/new/

https://reviews.llvm.org/D72242





More information about the cfe-commits mailing list