[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 14 08:03:00 PST 2020


aaron.ballman added a comment.

In D72217#1819678 <https://reviews.llvm.org/D72217#1819678>, @njames93 wrote:

> In D72217#1819437 <https://reviews.llvm.org/D72217#1819437>, @aaron.ballman wrote:
>
> > Do you need someone to commit this on your behalf? (If you plan to continue contributing, which I hope you do, it may be a good time for you to obtain commit privileges: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access but I am happy to commit on your behalf if you'd prefer.)
>
>
> For now I would appreciate it, I have fired off an email though, cheers.


Happy to do so -- can you upload a rebased patch? I am getting merge conflicts:

  c:\llvm-project>git apply C:\Users\aballman\Desktop\D72217.diff
  C:/Users/aballman/Desktop/D72217.diff:402: trailing whitespace.
    Adds pointer and ``const`` qualifications to ``auto``-typed variables
  C:/Users/aballman/Desktop/D72217.diff:468: trailing whitespace.
  make it obvious if a ``auto`` typed variable is a pointer, constant pointer or
  C:/Users/aballman/Desktop/D72217.diff:469: trailing whitespace.
  constant reference. This check will transform ``auto`` to ``auto *`` when the
  error: patch failed: clang-tools-extra/docs/clang-tidy/checks/list.rst:397
  error: clang-tools-extra/docs/clang-tidy/checks/list.rst: patch does not apply


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72217/new/

https://reviews.llvm.org/D72217





More information about the cfe-commits mailing list