[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

> Thank you for looking into this; I'll start building diff14 to test locally.

Thanks :)

> I'm good with merging this checker as-is, as long as it is not enabled by default.

Which part shall be disabled in your opinion? The whole check? that would not work xD But I think both `value` and `reference` analysis is good enough. The issue with `auto&` is only a problem in templates, where different instantiations result to different modification-status if the type of the reference depends on the template instantiation.
Its not that common, but a false positive. :(

But i think it is already valueable in day-to-day programming and to modernize code, lets see what aaron says :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943