[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 10 10:50:37 PST 2020


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:14
+
+   Specify extra functions to flag on that act similarily to memset.
+   Default is an empty string
----------------
Please enclose memset in double back-ticks. Same for other options.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:15
+   Specify extra functions to flag on that act similarily to memset.
+   Default is an empty string
+   The check will always detect the function: ``memset``
----------------
Please append dot. Same for other options.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:16
+   Default is an empty string
+   The check will always detect the function: ``memset``
+
----------------
This is tautological because extra functions assume additions to functions handled by default. Same for other options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72488/new/

https://reviews.llvm.org/D72488





More information about the cfe-commits mailing list