[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno marked an inline comment as done.
bruno added a comment.





================
Comment at: clang/lib/Serialization/ASTReader.cpp:9286
+          false /*UseCanonicalDecls*/);
+      (void)Ctx.IsEquivalent(D, Canon);
+    }
----------------
martong wrote:
> Would it be possible to check the structural non-equivalency with `ODRHash`?
> I wonder if the `ODRHash` of the two Decls are different in this case or not.
> `ASTStructuralEquivalency` and `ODRHash` seems to serve a very similar use case, however, AFAIK in the rest of the ASTReader code `ODRHash` is used exclusively.
> 
> (On a long term, I am thinking about that perhaps `ASTImporter` could use ODRHash instead of ASTStructuralEquivalency.)
Great idea. Updated the patch with another approach!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71734/new/

https://reviews.llvm.org/D71734