[clang] 4711512 - Fix oversight in AST traversal helper

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 5 14:00:41 PST 2020


Can you also include more detail in commit logs than this? It doesn't
explain why this is an oversight, which makes code archaeology harder later.

On Sun, Jan 5, 2020, 3:32 PM Stephen Kelly via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

>
> Author: Stephen Kelly
> Date: 2020-01-05T20:27:37Z
> New Revision: 471151238438201f3fe365a7784f1a091328e46c
>
> URL:
> https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c
> DIFF:
> https://github.com/llvm/llvm-project/commit/471151238438201f3fe365a7784f1a091328e46c.diff
>
> LOG: Fix oversight in AST traversal helper
>
> Added:
>
>
> Modified:
>     clang/lib/AST/Expr.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/clang/lib/AST/Expr.cpp b/clang/lib/AST/Expr.cpp
> index 5c9ceac854cf..73ddbc62482d 100644
> --- a/clang/lib/AST/Expr.cpp
> +++ b/clang/lib/AST/Expr.cpp
> @@ -3026,7 +3026,7 @@ Expr *Expr::IgnoreUnlessSpelledInSource() {
>    Expr *LastE = nullptr;
>    while (E != LastE) {
>      LastE = E;
> -    E = E->IgnoreImplicit();
> +    E = E->IgnoreParenImpCasts();
>
>      auto SR = E->getSourceRange();
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200105/3f9babb0/attachment.html>


More information about the cfe-commits mailing list