[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 3 12:01:20 PST 2020


JonasToth marked 2 inline comments as done.
JonasToth added inline comments.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5224
 
+/// Matches QualType nodes that are of function pointer type.
+///
----------------
I will remove those later. They are not used.
Tidying up will be done, once i dont find any false positives/false transformations anymore.


================
Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:27
 
-AST_MATCHER_P(Expr, maybeEvalCommaExpr,
-             ast_matchers::internal::Matcher<Expr>, InnerMatcher) {
-  const Expr* Result = &Node;
+AST_MATCHER_P(Expr, maybeEvalCommaExpr, ast_matchers::internal::Matcher<Expr>,
+              InnerMatcher) {
----------------
these are formating changes, i will revert them / apply them as separate commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943





More information about the cfe-commits mailing list