[PATCH] D71939: clang-format: fix conflict between FormatStyle::BWACS_MultiLine and BeforeCatch/BeforeElse

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 30 09:36:48 PST 2019


MyDeveloperDay added a comment.

I think generally speaking this looks ok, I'm ok with the extra clause, as long as it's clear what it's doing



================
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:329
                  : 0;
+    } else if (I[1]->First->is(tok::l_brace) &&
+               TheLine->First->isOneOf(tok::kw_else, tok::kw_catch) &&
----------------
nit: maybe leave a comment explaining the need for the extra clause


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71939/new/

https://reviews.llvm.org/D71939





More information about the cfe-commits mailing list