[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 23 12:55:13 PST 2019


MaskRay added inline comments.


================
Comment at: clang/test/Frontend/absolute-paths-symlinks.c:15
+
+// REQUIRES: shell
----------------
rnk wrote:
> I wish we had a more precise feature to indicate symlink support, but this is what we do elsewhere, so there's nothing to do here.
I wrote:

```
## Don't make symlinks on Windows.
# UNSUPPORTED: system-windows
```

in D71302. Yeah, please tell me which precise feature I should use :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70527/new/

https://reviews.llvm.org/D70527





More information about the cfe-commits mailing list