[PATCH] D71686: Fix false positive in magic number checker

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 20 12:49:57 PST 2019


aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cpp:129
+                        // expanded class enumeration value.
+                        if (Parent.get<CStyleCastExpr>())
+                          return true;
----------------
So will this no longer treat *any* C-style cast as being a magic number? e.g., `int i; i = (int)12;`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71686/new/

https://reviews.llvm.org/D71686





More information about the cfe-commits mailing list