[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

Steven Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 12:34:30 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rG9366397f057d (authored by steven_wu).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69893/new/

https://reviews.llvm.org/D69893

Files:
  libunwind/src/DwarfInstructions.hpp


Index: libunwind/src/DwarfInstructions.hpp
===================================================================
--- libunwind/src/DwarfInstructions.hpp
+++ libunwind/src/DwarfInstructions.hpp
@@ -433,7 +433,7 @@
       // pick from
       reg = addressSpace.get8(p);
       p += 1;
-      value = sp[-reg];
+      value = sp[-(int)reg];
       *(++sp) = value;
       if (log)
         fprintf(stderr, "duplicate %d in stack\n", reg);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69893.234597.patch
Type: text/x-patch
Size: 434 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20191218/e633da55/attachment.bin>


More information about the cfe-commits mailing list