[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Alexey Sotkin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 18 03:18:32 PST 2019


AlexeySotkin added a comment.

In D71460#1783390 <https://reviews.llvm.org/D71460#1783390>, @asavonic wrote:

> What about `get_image_num_mip_levels` functions defined in the extension specification?
>
> Edit: I mean, should the `get_image_num_mip_levels(write_only img)` function be only available if `cl_khr_mipmap_image_writes` extension is supported, or `cl_khr_mipmap_image` is enough?


I think `cl_khr_mipmap_image` is enough, because "the `cl_khr_mipmap_image_writes` extension adds built-in functions that can be used to **write** a mip-mapped image", while `get_image_num_mip_levels(write_only img)` only retrieve a property of the image.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71460/new/

https://reviews.llvm.org/D71460





More information about the cfe-commits mailing list