[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 13:15:35 PST 2019


efriedma added a comment.

> Perhaps we can clarify the intent that the non-faulting mode may have side-effects by renaming the flag to something like NonFaultingWithSideEffects?

We could specify something like that... but that probably requires some changes to target-independent DAGCombine, and it's sort of a weird edge case given that no other loads have that kind of side-effect. If we are going to make a change like that to MachineMemOperand, we'd probably want to propose it on llvmdev.  I'd prefer a little extra code here to avoid that rabbit hole.  We're busy enough already with other substantial changes to target-independent code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71556/new/

https://reviews.llvm.org/D71556





More information about the cfe-commits mailing list