[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 17 06:59:00 PST 2019


Eugene.Zelenko added a comment.

Please add documentation and mention new check in Release Notes.



================
Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:10
+#include "UnsignedSubtractionCheck.h"
+
+#include "../utils/Matchers.h"
----------------
Unnecessary empty line.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:137
+}
+}  // namespace bugprone
+}  // namespace tidy
----------------
Please separate with empty line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71607/new/

https://reviews.llvm.org/D71607





More information about the cfe-commits mailing list