[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

Fri Dec 13 15:00:00 PST 2019

teemperor marked an inline comment as done.
teemperor added a comment.

In D71397#1782537 <https://reviews.llvm.org/D71397#1782537>, @lhames wrote:

> Side note: This https://reviews.llvm.org/D39111 seems related. The patch has languished as I have been busy with other work, but if it would be useful for you guys I'd be happy to try to land it.

Moving ExternalASTSource to that system would also work, but that would add yet another dependency to D71398 <https://reviews.llvm.org/D71398> (which is removing really gnarly code). But otherwise this seems like something we could use here (and also in LLDB).

I would prefer landing this as-is because it is just doing the same we do in other places in LLVM. Afterwards migrating the whole RTTI system in LLVM to a new system (whether that will be D39111 <https://reviews.llvm.org/D39111> or just a ClassID type) sounds good to me.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71397/new/

https://reviews.llvm.org/D71397