[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 13 08:24:31 PST 2019


nridge added a comment.

In D71345#1783587 <https://reviews.llvm.org/D71345#1783587>, @sammccall wrote:

> Indeed, sorry - I meant that if we incorporated it into an LSP server, there'd be no way to target it in methods that take a position rather than a selection (go to defn, hover etc).


Ah, right, I forgot that LSP tends to send positions rather than ranges as inputs. (I hope that changes in the future, e.g. an issue <https://github.com/microsoft/language-server-protocol/issues/377> is on file for hover.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71345/new/

https://reviews.llvm.org/D71345





More information about the cfe-commits mailing list