[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Andrew Savonichev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 13 04:54:18 PST 2019


asavonic added a comment.

What about `get_image_num_mip_levels` functions defined in the extension specification?



================
Comment at: clang/lib/Headers/opencl-c.h:14780
 
 void __ovld write_imagef(read_write image2d_depth_t image, int2 coord, int lod, float color);
 void __ovld write_imagef(read_write image2d_array_depth_t image, int4 coord, int lod, float color);
----------------
Shouldn't "color" be renamed to "depth" here as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71460/new/

https://reviews.llvm.org/D71460





More information about the cfe-commits mailing list