[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 13 01:09:00 PST 2019


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1913
+
+  // Specializations needs to be marked "inline".
+  ExtraFiles["a.h"] = R"cpp(
----------------
hokein wrote:
> could you add a test case for  partial template specializations? I think we don't need the inline for that.
there's no such thing as partial specialization for functions, and we don't allow inlining inside templated classes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68261/new/

https://reviews.llvm.org/D68261





More information about the cfe-commits mailing list