[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 10 17:05:09 PST 2019


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Amazing!



================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:161
     if (Ints[i].EnumName.size() < 40)
-      OS << std::string(40-Ints[i].EnumName.size(), ' ');
+      OS << std::string(40 - Ints[i].EnumName.size(), ' ');
     OS << " // " << Ints[i].Name << "\n";
----------------
`OS.indent(40 - Ints[i].EnumName.size());`


================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:166
+  // Emit num_intrinsics into the target neutral enum.
+  if (IntrinsicPrefix == "") {
+    OS << "    num_intrinsics = " << (Ints.size() + 1) << "\n";
----------------
`IntrinsicPrefix.empty()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71320/new/

https://reviews.llvm.org/D71320





More information about the cfe-commits mailing list