[PATCH] D71322: [analyzer] CStringChecker: Fix overly eager assumption that memcmp arguments overlap.

[Csaba Dabis via Phabricator via cfe-commits]

Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.

Could you write a test for `strcmp` please? I have found out the `evalMemcmp` behaves differently than `evalStrcmp`. However when the `memcmp` is going to be used like `strcmp`/`strncmp` the ideal would be to delegate the work to `evalStrcmp`. At the moment there is no connection between the two evaluation at all, which surprised me at first.

Other than that I really like the idea to remove overhead. Thanks!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71322/new/

https://reviews.llvm.org/D71322