[PATCH] D70613: Add method to ignore invisible AST nodes

[Stephen Kelly via Phabricator via cfe-commits]

steveire marked 10 inline comments as done.
steveire added a comment.

It wasn't possible to add the `const` because of the return type.



================
Comment at: clang/include/clang/AST/Expr.h:769-770
+  /// implicit conversions.
+  Expr *IgnoreInvisible();
+  const Expr *IgnoreInvisible() const {
+    return const_cast<Expr *>(this)->IgnoreInvisible();
----------------
aaron.ballman wrote:
> `Invisible` is a bit of an odd term because the AST nodes themselves are in fact visible within the AST. I think this means "invisible" as in "not corresponding directly to syntax the user wrote". Bikeshedding some other names:
> 
> * IgnoreAllImplicitExprs
> * IgnoreAllImplicitNodes
> * IgnoreNodesNotWrittenByUser
> * IgnoreNotWrittenInSource
> 
> other suggestions welcome.
> 
Changed as discussed on IRC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70613/new/

https://reviews.llvm.org/D70613