[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added a comment.

In D71241#1776798 <https://reviews.llvm.org/D71241#1776798>, @ABataev wrote:

> You're merging different functions as multiversiin  variants. I don't think this right to overcomplicate the semantics of multiversion functions just because you want to do it.


I am actually not doing that here. What over complication do you mean exactly? Especially because this patch does not touch multi-version functions at all I'm confused by your comment.



================
Comment at: clang/lib/Sema/SemaOverload.cpp:9725
+
+  // TODO: Handle template instantiation
+  Best->Function = cast<FunctionDecl>(
----------------
ABataev wrote:
> Implement all todos and check it with the size of the code where you just need to iterate through all the va4iants and call the existing functions to emit their aliases.
We do not emit aliases at all with this approach. Emitting aliases does not work for the generic case, e.g., the construct selector trait.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71241/new/

https://reviews.llvm.org/D71241