[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 19:44:53 PST 2019


NoQ added a comment.

Usually this kind of code is hard to re-use because all use cases require different definitions of "has descendant". We already have at least 3 such definitions floating around and we can't re-use them.

Even in the world of ASTMatchers the actual `hasDescendant` matcher is basically an anti-pattern as you always want to use a matcher for a //specific// parent-child relation instead (cf. http://lists.llvm.org/pipermail/cfe-dev/2019-September/063260.html).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70805/new/

https://reviews.llvm.org/D70805





More information about the cfe-commits mailing list