[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 16:11:33 PST 2019


rnk abandoned this revision.
rnk added a comment.

I think this isn't necessary. I think I got most of the value of this in rG60573ae6fe509b618dc6a2c5c55d921bccd77608 <https://reviews.llvm.org/rG60573ae6fe509b618dc6a2c5c55d921bccd77608>, and we don't need two AttrBase.h / Attr.h headers in the long run. This is how many files depend on Attr.h now:

  $ ninja -t deps | grep 'AST.Attr\.h' | wc -l
  683

I think most deps are through Sema.h and ASTMatchers.h:

  $ ninja -t deps | grep 'Sema.Sema\.h' | wc -l
  102
  $ ninja -t deps | grep 'ASTMatchers.ASTMatchers\.h' | wc -l
  391


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70627/new/

https://reviews.llvm.org/D70627





More information about the cfe-commits mailing list