[PATCH] D71000: [AArch64][SVE] Implement intrinsics for non-temporal loads & stores

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 12:44:11 PST 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10800
+                                MINode->getOperand(3), DAG.getUNDEF(LoadVT),
+                                MINode->getOperand(2), PassThru,
+                                MINode->getMemoryVT(), MINode->getMemOperand(),
----------------
Offset (the fifth argument) is supposed to be a scalar, not a vector.  Probably nothing actually checks that for loads that aren't pre/post-indexed.  (Same applies to MSTORE.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71000/new/

https://reviews.llvm.org/D71000





More information about the cfe-commits mailing list