[PATCH] D71179: [OpenMP][WIP] Initial support for `begin/end declare variant`

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added inline comments.


================
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:72
-#ifndef _OPENMP
-__DEVICE__ int fpclassify(float __x) {
-  return __builtin_fpclassify(FP_NAN, FP_INFINITE, FP_NORMAL, FP_SUBNORMAL,
----------------
tra wrote:
> Please keep fpclassify in place. It's been available in this header for a long time and it *is* needed.
> 
> 
> 
Done.


================
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:462
-#ifndef _OPENMP
-using ::scalblnf;
-#endif
----------------
tra wrote:
> I think only `#ifdef` should be removed here. `scalblnf` itself should remain.
I misinterpreted the TODOs, here and above. That is why I removed code. Sorry for the noise.


================
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1724
-#ifndef _OPENMP
-__DEVICE__ double scalbln(double __a, long __b) {
-  if (__b > INT_MAX)
----------------
tra wrote:
> Ditto here. Only preprocessor statements should be removed.
Yeah, my bad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71179/new/

https://reviews.llvm.org/D71179