[clang] ec71238 - Fix clang -Wcovered-switch-default after llvmorg-10-init-11484-g6626e5a06a9

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 9 11:32:29 PST 2019


Author: Fangrui Song
Date: 2019-12-09T11:32:22-08:00
New Revision: ec71238916dec90c2ef9435af5979a345a447575

URL: https://github.com/llvm/llvm-project/commit/ec71238916dec90c2ef9435af5979a345a447575
DIFF: https://github.com/llvm/llvm-project/commit/ec71238916dec90c2ef9435af5979a345a447575.diff

LOG: Fix clang -Wcovered-switch-default after llvmorg-10-init-11484-g6626e5a06a9

We need to place llvm_unreachable after switch to work around the GCC
warning.

Added: 
    

Modified: 
    clang/lib/Sema/SemaDeclCXX.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp
index d0857a5de817..0a7c41c1eda6 100644
--- a/clang/lib/Sema/SemaDeclCXX.cpp
+++ b/clang/lib/Sema/SemaDeclCXX.cpp
@@ -7103,7 +7103,6 @@ class DefaultedComparisonVisitor {
     ResultList Results;
 
     switch (DCK) {
-    default:
     case DefaultedComparisonKind::None:
       llvm_unreachable("not a defaulted comparison");
 
@@ -7118,6 +7117,7 @@ class DefaultedComparisonVisitor {
           ParamLvalType, getDerived().getCompleteObject()));
       return Results;
     }
+    llvm_unreachable("");
   }
 
 protected:
@@ -7593,7 +7593,6 @@ class DefaultedComparisonSynthesizer
       return StmtError();
 
     switch (DCK) {
-    default:
     case DefaultedComparisonKind::None:
       llvm_unreachable("not a defaulted comparison");
 
@@ -7660,6 +7659,7 @@ class DefaultedComparisonSynthesizer
       //   Otherwise, the operator function yields x @ y.
       return Op.get();
     }
+    llvm_unreachable("");
   }
 
   /// Build "static_cast<R>(E)".


        


More information about the cfe-commits mailing list