[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

Kamil Rytarowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 15:12:59 PST 2019


krytarowski added inline comments.


================
Comment at: compiler-rt/test/sanitizer_common/netbsd_commands/run_noaslr.sh:4
+PATH=${PATH}:/usr/sbin
+paxctl +a "${1}"
+exec "${@}"
----------------
eugenis wrote:
> krytarowski wrote:
> > I propose to use `/usr/bin/paxctl` as it will be PATH and environment independent. We already use this direct path approach in pkgsrc.
> It this path correct? /usr/sbin in the code vs /usr/bin in the comment.
It is correct. I made a typo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70958/new/

https://reviews.llvm.org/D70958





More information about the cfe-commits mailing list