[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 5 12:45:21 PST 2019


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:384
+      else
+        assert(EndLoc.isValid() && "no location for inlineable cleanup calls");
+    }
----------------
vsk wrote:
> The braces around the `else` block are probably needed in the NDEBUG build.
No, this should be fine. The `;` is not part of the macro.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71042/new/

https://reviews.llvm.org/D71042





More information about the cfe-commits mailing list